Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old/unused classes #170

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Conversation

jtraglia
Copy link
Contributor

PR Description

It's my understanding that these files were used in the original implementation, but are not longer needed.

  • DataSource was used for the node table.
  • HoleyList was used for the node index table.
  • SingleValueSource was used for the home node.

If these aren't being used, I think it's a good idea to remove them.

I'm leaving ExpirationSet because it is used. But I think it could be moved to the storage directory.

@jtraglia jtraglia changed the title Remove old/unused database classes Remove old/unused classes Nov 15, 2022
@jtraglia
Copy link
Contributor Author

Not sure what's up with CI. I think it needs to be kicked.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Definitely worth clearing out dead code.

@ajsutton ajsutton merged commit 7da0181 into Consensys:master Nov 15, 2022
@jtraglia jtraglia deleted the remove-old-db-files branch November 16, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants