Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bouncy Castle to 1.76 using the Java 8 variant #172

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 3, 2023

PR Description

Upgrading Bouncy Castle to the latest version and switching to the variant that requires at least Java 8.

Does anyone knows if there is risk in dropping per Java 8 support?

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In any case, we set source and target compatibility to 11, so we don't support 8, so no worries there.

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 merged commit 575743a into master Dec 6, 2023
@fab-10 fab-10 deleted the update-bouncycastle branch December 6, 2023 13:55
@fab-10
Copy link
Contributor Author

fab-10 commented Dec 6, 2023

@StefanBratanov could you help with the publishing failure on main?

@StefanBratanov
Copy link
Contributor

@StefanBratanov could you help with the publishing failure on main?

Yeah, I am looking into it. Looks like it has been failing for a while.

@StefanBratanov
Copy link
Contributor

@StefanBratanov could you help with the publishing failure on main?

Yeah, I am looking into it. Looks like it has been failing for a while.

@fab-10 Done. Publishing on last commit looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants