Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NPE in node session #174

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fixed NPE in node session #174

merged 3 commits into from
Sep 20, 2023

Conversation

rolfyone
Copy link
Contributor

I'm not sure this can actually happen easily, but added guards around map entries coming back empty etc. given they're closing down we'll just log debug messages.

fixes #173

I'm not sure this can actually happen easily, but added guards around map entries coming back empty etc. given they're closing down we'll just log debug messages.
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a nit.

@rolfyone rolfyone merged commit 9fb4203 into Consensys:master Sep 20, 2023
@rolfyone rolfyone deleted the 173 branch September 20, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE during handshake
2 participants