Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4/IPv6 additional handling + dependencies updates #180

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Jun 25, 2024

PR Description

  • Upgrade ilbraries + gradle
  • Align usage of NewAddressHandler to be compatible when using both IPv4 and IPv6

Fixed Issue(s)

related to #176

@StefanBratanov StefanBratanov changed the title Dependencies updates + minor refactor IPv4/IPv6 additional handling + dependencies updates Jun 25, 2024
Copy link
Contributor

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit: Just a bit uncomfortable that switches handling IPv4/IPv6 cases are spreaded across classes. Any chances we could group them in a single place?

@StefanBratanov
Copy link
Contributor Author

LGTM nit: Just a bit uncomfortable that switches handling IPv4/IPv6 cases are spreaded across classes. Any chances we could group them in a single place?

Yeah, I agree about the switches handling. Added a commit to simplify using ternary operators. I think I am more likely to raise an issue to think about way to handle all those IPv4/IPv6 handling better. It will require some thought.

@StefanBratanov StefanBratanov enabled auto-merge (squash) June 26, 2024 07:52
@StefanBratanov StefanBratanov merged commit c66f3d7 into Consensys:master Jun 26, 2024
3 checks passed
@StefanBratanov StefanBratanov deleted the dep_updates_minor_nit branch June 26, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants