Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discvv5.1 - the latest spec updates #76

Merged
merged 99 commits into from
Oct 13, 2020

Commits on Sep 16, 2020

  1. Configuration menu
    Copy the full SHA
    83c5da3 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Configuration menu
    Copy the full SHA
    e73d9d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Configuration menu
    Copy the full SHA
    65dbad8 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Configuration menu
    Copy the full SHA
    8fd0787 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eeab34e View commit details
    Browse the repository at this point in the history
  3. Apply spotless

    Nashatyrev committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    90a25be View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Configuration menu
    Copy the full SHA
    8e3e415 View commit details
    Browse the repository at this point in the history
  2. Minor updates

    Nashatyrev committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    0055968 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    47dbb52 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    91ed52e View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Configuration menu
    Copy the full SHA
    04bfd6b View commit details
    Browse the repository at this point in the history
  2. Add WhoAreYouPacketTest

    Nashatyrev committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    7701748 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d03656 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dfa6ad7 View commit details
    Browse the repository at this point in the history
  5. Apply spotless

    Nashatyrev committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    883cda8 View commit details
    Browse the repository at this point in the history
  6. Fix warns and licences

    Nashatyrev committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    9966bea View commit details
    Browse the repository at this point in the history
  7. Fix the test

    Nashatyrev committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    0405c2f View commit details
    Browse the repository at this point in the history
  8. Fix the test

    Nashatyrev committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    81c7a54 View commit details
    Browse the repository at this point in the history
  9. Draft commit

    Nashatyrev committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    2756f88 View commit details
    Browse the repository at this point in the history
  10. Add some javadoc

    Nashatyrev committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    df99cf7 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Process the case when in AUTHORIZED session state inbound message cou…

    …ldn't be decrypted - send WHOAREYOU in this case
    Nashatyrev committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    d6c667e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8601f95 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d21af5d View commit details
    Browse the repository at this point in the history
  4. Rename the class

    Nashatyrev committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    12c4a7a View commit details
    Browse the repository at this point in the history
  5. Apply spotless

    Nashatyrev committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    af42f90 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Configuration menu
    Copy the full SHA
    5913f5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    784c3f3 View commit details
    Browse the repository at this point in the history
  3. Use explicit Flag codes

    Nashatyrev committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    c2427b0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6221320 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    12cfd65 View commit details
    Browse the repository at this point in the history
  6. Fix typo in class name

    Nashatyrev committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    bd2f54d View commit details
    Browse the repository at this point in the history
  7. Fix param name srcNodeId -> destNodeId. Name params more explicitly (…

    …destNodeId instead of nodeId)
    Nashatyrev committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    10fa187 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d65bcdf View commit details
    Browse the repository at this point in the history
  9. Apply spotless

    Nashatyrev committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    091a919 View commit details
    Browse the repository at this point in the history
  10. Reduce the number of static factory methods in 5.1 Packet interfaces.…

    … Leave just Header.create* and *Packet.create()
    Nashatyrev committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    a77ff29 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0bb80a7 View commit details
    Browse the repository at this point in the history
  12. Apply spotless

    Nashatyrev committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    7d627af View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    84a8118 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    91d7e4d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    640b118 View commit details
    Browse the repository at this point in the history
  16. Apply spotless

    Nashatyrev committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    0aaee3a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Fix wording

    Co-authored-by: mbaxter <meredith.baxter@consensys.net>
    Nashatyrev and mbaxter committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    3e7ee9a View commit details
    Browse the repository at this point in the history
  2. Large outbound packet size is rather the error

    Co-authored-by: mbaxter <meredith.baxter@consensys.net>
    Nashatyrev and mbaxter committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    50748e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    69e5ee9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c7b5611 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'origin/feature/disc-v5.1' into feature/…

    …disc-v5.1
    
    # Conflicts:
    #	src/main/java/org/ethereum/beacon/discovery/message/handler/FindNodeHandler.java
    Nashatyrev committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    7f648c5 View commit details
    Browse the repository at this point in the history
  6. Apply spotless

    Nashatyrev committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    f1b879c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3b62935 View commit details
    Browse the repository at this point in the history
  8. Merge remote-tracking branch 'Pegasys/master' into feature/talk-support

    # Conflicts:
    #	src/main/java/org/ethereum/beacon/discovery/message/DiscoveryV5Message.java
    #	src/main/java/org/ethereum/beacon/discovery/message/FindNodeMessage.java
    #	src/test/java/org/ethereum/beacon/discovery/community/MessageEncodingTest.java
    Nashatyrev committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    2e46963 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    eef00f1 View commit details
    Browse the repository at this point in the history
  10. Add TALKREQ handling

    Nashatyrev committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    fe9263a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    737b921 View commit details
    Browse the repository at this point in the history
  12. Fix bug in validation

    Nashatyrev committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    05ca4cd View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Refactor task handling. Remove unnecessary intermediate classes. Make…

    … it possible to return a value future from discovery call
    Nashatyrev committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    e59a075 View commit details
    Browse the repository at this point in the history
  2. Generify Response

    Nashatyrev committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    470716d View commit details
    Browse the repository at this point in the history
  3. Implement TALKREQ

    Nashatyrev committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9c9675a View commit details
    Browse the repository at this point in the history
  4. Fix warns

    Nashatyrev committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    bdf7111 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dba8915 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e9f0671 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f6afe20 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Configuration menu
    Copy the full SHA
    f2899f9 View commit details
    Browse the repository at this point in the history
  2. Check min packet size

    Nashatyrev committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    125159c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Configuration menu
    Copy the full SHA
    53851ac View commit details
    Browse the repository at this point in the history
  2. Remove obsolete class

    Nashatyrev committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    e362b3b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c83b49 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1ff8979 View commit details
    Browse the repository at this point in the history
  5. Remove confusing DiscoveryV5Message wrapper and add DiscoveryMessageD…

    …ecoder instead. Add an abstract Message class (aka for all discovery versions)
    Nashatyrev committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    79a82d3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cf02712 View commit details
    Browse the repository at this point in the history
  7. Apply spotless

    Nashatyrev committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    8db508c View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Initial refactor to reflect the latest Discv5.1 spec changes:

    - packet header fields reorg
    - maskingIV mixed up to message encryption associated data
    - the whole WhoAreYou message is mixed for id-signature
    - WhoAreYou has no more 'src-node-id' thus we need to find session via original-nonce
    Nashatyrev committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    e263e65 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feature/talk-support' into feature/v5.1-last-updates-1

    # Conflicts:
    #	src/main/java/org/ethereum/beacon/discovery/packet/impl/MessagePacketImpl.java
    #	src/test/java/org/ethereum/beacon/discovery/packet/OrdinaryMessagePacketTest.java
    Nashatyrev committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    8d3ba7b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    228f691 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20e1f0e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ce90f4e View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'Pegasys/master' into feature/v5.1-last-…

    …updates-1
    
    # Conflicts:
    #	src/main/java/org/ethereum/beacon/discovery/DiscoveryManagerImpl.java
    #	src/main/java/org/ethereum/beacon/discovery/packet/impl/MessagePacketImpl.java
    #	src/main/java/org/ethereum/beacon/discovery/pipeline/handler/NewTaskHandler.java
    #	src/main/java/org/ethereum/beacon/discovery/pipeline/handler/NextTaskHandler.java
    #	src/main/java/org/ethereum/beacon/discovery/pipeline/handler/WhoAreYouPacketHandler.java
    #	src/main/java/org/ethereum/beacon/discovery/schema/NodeSession.java
    #	src/test/java/org/ethereum/beacon/discovery/HandshakeHandlersTest.java
    #	src/test/java/org/ethereum/beacon/discovery/packet/OrdinaryMessagePacketTest.java
    Nashatyrev committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    38ad5ef View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f77c373 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1c03fb4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9c3cac3 View commit details
    Browse the repository at this point in the history
  10. Fix warnings

    Nashatyrev committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    0dbbe5c View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Add Discovery test server

    Nashatyrev committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    874fcc1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    229765e View commit details
    Browse the repository at this point in the history
  3. Sptoless apply

    Nashatyrev committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    a8c86eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aa7f492 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Configuration menu
    Copy the full SHA
    bb70bfe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    01b1df2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6306c38 View commit details
    Browse the repository at this point in the history
  4. Remove obsolete tests

    Nashatyrev committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    1255546 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5515c10 View commit details
    Browse the repository at this point in the history
  6. If another ordinary message received after WhoAreYou packet was sent,…

    … we should again send another WhoAreYou packet
    Nashatyrev committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    2891f5c View commit details
    Browse the repository at this point in the history
  7. If a session was dropped on remote host we are sending packets instea…

    …d of putting them into await queue. So when the WhoAreYou packet is received 'unexpectedly' we should take a SENT packet for resending
    Nashatyrev committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    d8f1bd6 View commit details
    Browse the repository at this point in the history
  8. Sptoless apply

    Nashatyrev committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    e3bd4e6 View commit details
    Browse the repository at this point in the history
  9. Fix the test

    Nashatyrev committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    8d03dac View commit details
    Browse the repository at this point in the history
  10. Sptoless apply

    Nashatyrev committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    362703d View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. Configuration menu
    Copy the full SHA
    a0434fb View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Configuration menu
    Copy the full SHA
    d0d3cc8 View commit details
    Browse the repository at this point in the history
  2. Spotless apply

    Nashatyrev committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    df8b742 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c9e1c4 View commit details
    Browse the repository at this point in the history
  4. Spotless apply

    Nashatyrev committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    35c192f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    94ea4e8 View commit details
    Browse the repository at this point in the history