Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section with example for configuring an eth2 public testnet #135

Merged
merged 5 commits into from
Aug 22, 2022

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Aug 22, 2022

We had two users separately make the same mistake when setting up web3signer on goerli. They missed adding the --network flag to the eth2 subcommand. They both used the Get Started/Start Web3signer page to configure.

Even though it's mentioned in a note on this page, I have added an additional section to show an example of running with a public testnet (goerli).

Also, I have prioritised the eth2 examples over eth1 further up the page since eth2 is this product's main use case.

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

After creating your PR and tests have finished

Make sure that:

Preview

https://pegasys-web3signer--135.com.readthedocs.build/en/135/HowTo/Get-Started/Start-Web3Signer/

siladu added 2 commits August 22, 2022 12:03
Emphasize eth2 examples over eth1 since it is this product's main use case
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if you approve of my suggestions.

docs/HowTo/Get-Started/Start-Web3Signer.md Outdated Show resolved Hide resolved
docs/HowTo/Get-Started/Start-Web3Signer.md Outdated Show resolved Hide resolved
docs/HowTo/Get-Started/Start-Web3Signer.md Outdated Show resolved Hide resolved
siladu and others added 3 commits August 22, 2022 03:20
Co-authored-by: bgravenorst <50852695+bgravenorst@users.noreply.github.com>
Co-authored-by: bgravenorst <50852695+bgravenorst@users.noreply.github.com>
Co-authored-by: bgravenorst <50852695+bgravenorst@users.noreply.github.com>
@siladu siladu merged commit 0ff1948 into Consensys:master Aug 22, 2022
@siladu siladu deleted the public-testnet-example branch August 22, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants