Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up eddsa code generation #160

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Clean up eddsa code generation #160

merged 7 commits into from
Mar 17, 2022

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Mar 16, 2022

Picked up few inconsistencies between twistededwards and bandersnatch packages.

Refactor code generation to generate everything from a template. (generics generics where are you 🙄 ).

@gbotrel gbotrel added the cleanup Suggestion to clean up the code label Mar 16, 2022
@gbotrel gbotrel added this to the v0.7.0 milestone Mar 16, 2022
@gbotrel gbotrel requested a review from yelhousni March 16, 2022 19:48
yelhousni
yelhousni approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The shared formulae enable templating although slightly slower in the case (a=-1).

ecc/bls12-377/twistededwards/point.go Outdated Show resolved Hide resolved
ecc/bls12-377/twistededwards/point.go Show resolved Hide resolved
ecc/bls12-377/twistededwards/point.go Show resolved Hide resolved
internal/generator/edwards/template/point.go.tmpl Outdated Show resolved Hide resolved
internal/generator/edwards/template/point.go.tmpl Outdated Show resolved Hide resolved
@gbotrel gbotrel merged commit d6352e5 into develop Mar 17, 2022
@gbotrel gbotrel deleted the refactor-eddsa branch July 29, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yelhousni yelhousni yelhousni approved these changes

Assignees
No one assigned
Labels
cleanup Suggestion to clean up the code
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gbotrel @yelhousni