Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #267: fp.Inverse heap alloc #272

Merged
merged 6 commits into from
Nov 21, 2022
Merged

fix #267: fp.Inverse heap alloc #272

merged 6 commits into from
Nov 21, 2022

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Nov 21, 2022

Quick one;

The issue was Inverse had a code path that called Exp which had a path that called Inverse.. uselessly forcing heap allocations. (when Inverse calls Exp it is a special edge-sanity case which doesn't need to call the main Exp function).

@gbotrel gbotrel added the perf label Nov 21, 2022
@gbotrel gbotrel added this to the v0.9.0 milestone Nov 21, 2022
@gbotrel gbotrel requested a review from Tabaie November 21, 2022 20:45
Base automatically changed from refactor/hash2fp-for-all to develop November 21, 2022 22:14
@gbotrel gbotrel merged commit 94237b9 into develop Nov 21, 2022
@gbotrel gbotrel deleted the gbotrel/issue267 branch November 21, 2022 22:17
@gbotrel gbotrel linked an issue Dec 5, 2022 that may be closed by this pull request
fp.Inverse(&x): moves x to the heap #267
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabaie Tabaie Tabaie approved these changes

Assignees
No one assigned
Labels
perf
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

fp.Inverse(&x): moves x to the heap
2 participants
@gbotrel @Tabaie