Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

304 field agnostic fiat shamir challenge names #308

Merged
merged 34 commits into from
Feb 10, 2023
Merged
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
7e3e95f
test: failing test
Tabaie Jan 12, 2023
0fc8672
fix: align challenge name, prepending with zeros to avoid field overflow
Tabaie Jan 12, 2023
d418e28
Merge pull request #305 from ConsenSys/test/fiatshamir-mimc
Tabaie Jan 12, 2023
6ed76e6
feat: decomposing long challenge names bn254
Tabaie Jan 16, 2023
31f311a
feat: generify Decomposition solution
Tabaie Jan 16, 2023
bb6a866
feat: more usable WriteString instead of "Decompose"
Tabaie Jan 16, 2023
eaa4a16
fix: eddsa to use WriteString
Tabaie Jan 16, 2023
7140b8f
fix: minor error
Tabaie Jan 16, 2023
06d1651
fix: eddsa: separate field element and non-field-element hash inputs
Tabaie Jan 16, 2023
71ad8f3
feat: hash.ToField compatible with hash.Hash
Tabaie Jan 26, 2023
4d64a23
build: generify bn254 mimc changes
Tabaie Jan 26, 2023
7a3a188
chore: staticcheck
Tabaie Jan 26, 2023
1415737
Merge branch 'chore/tobigintregular-deprecated' into 304-field-agnost…
Tabaie Jan 26, 2023
0f21a1d
fix: WriteString returns no error now
Tabaie Jan 26, 2023
96ff306
feat: edDSA to write element by element
Tabaie Jan 26, 2023
1a3bd6c
refactor: remove Decompose entirely
Tabaie Jan 30, 2023
861de54
chore: simpler dst for hash.WriteString
Tabaie Jan 30, 2023
17e54bc
fix: fiatshamir to write bindings one by one
Tabaie Jan 30, 2023
6679aff
feat: edDsa SignFr and VerifyFr
Tabaie Jan 30, 2023
81ae8e0
feat: signing interface changes and bn254 impl
Tabaie Jan 30, 2023
9cfd858
build: generify
Tabaie Jan 30, 2023
46d9e86
feat: Merkle tree to panic upon hash write error
Tabaie Feb 1, 2023
c15c344
Merge branch 'develop' into 304-field-agnostic-fiat-shamir-challenge-…
Tabaie Feb 2, 2023
389d5e4
revert: mimc to take in multiple elements
Tabaie Feb 2, 2023
fa19919
revert: remove SignNum and VerifyNum
Tabaie Feb 2, 2023
4dd000a
revert: Remove EdDSA SignNum and VerifyNum
Tabaie Feb 2, 2023
aa62b7e
build: weird staticcheck rule
Tabaie Feb 2, 2023
c9b64ee
revert: deleted mimc.Write documentation
Tabaie Feb 2, 2023
28a5eb3
test: mimc to write out its ins and outs
Tabaie Feb 2, 2023
8126db3
test: printfs in mimc
Tabaie Feb 2, 2023
630e96d
test: more debug output
Tabaie Feb 2, 2023
81a52c8
Merge branch 'develop' into 304-field-agnostic-fiat-shamir-challenge-…
Tabaie Feb 9, 2023
a83456a
fix: remove mimc printfs
Tabaie Feb 9, 2023
a40378c
refactor: remove ToField interface
Tabaie Feb 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion accumulator/merkletree/tree.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ func sum(h hash.Hash, data ...[]byte) []byte {

for _, d := range data {
// the Hash interface specifies that Write never returns an error
_, _ = h.Write(d)
_, err := h.Write(d)
if err != nil {
panic(err)
}
}
return h.Sum(nil)
}
Expand Down
46 changes: 0 additions & 46 deletions ecc/bls12-377/fr/mimc/decompose.go

This file was deleted.

53 changes: 0 additions & 53 deletions ecc/bls12-377/fr/mimc/decompose_test.go

This file was deleted.

48 changes: 28 additions & 20 deletions ecc/bls12-377/fr/mimc/mimc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 19 additions & 23 deletions ecc/bls12-377/twistededwards/eddsa/eddsa.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 0 additions & 46 deletions ecc/bls12-378/fr/mimc/decompose.go

This file was deleted.

53 changes: 0 additions & 53 deletions ecc/bls12-378/fr/mimc/decompose_test.go

This file was deleted.

Loading