Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid infinity point decoding throws error #363

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Mar 22, 2023

Thanks to @asanso and @kevaundray for reporting;

IETF spec we followed states:

The serialization of a point at infinity comprises a string of zero bytes, except that the metadata bits may be nonzero.

Previously, we did check the metadata bits and if they were signaling a point at infinity, discarded the rest of the buffer. We now add an additional check to ensure all the bytes are at 0.

@gbotrel gbotrel added the bug Something isn't working label Mar 22, 2023
@gbotrel gbotrel requested a review from yelhousni March 22, 2023 19:27
Copy link
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbotrel gbotrel merged commit c27657a into develop Mar 23, 2023
@gbotrel gbotrel deleted the fix/infencoding branch March 23, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants