Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
CopyWithFreshBuffer
CopyWithFreshBuffer
is a method ofRSis
whose intended role is to enable hashing in parallel by creating short-lived "clones" of the key. The present PR fixes a bug related to this.Description of the bug
Prior to this PR,
CopyWithFreshBuffer
would shallow copy the private fieldsbufM
,bufRes
andbufMValues
. As a result, attempting to use several copies of the same key concurrently results in a race condition (the same buffer being used by all the threads at the same time).The fix
The proposed fix is to also initialize the rest of the buffers