perf: optimize curve membership test #487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the curve membership test
IsOnCurve()
for all curves on both G1 and G2, by:b
Type of change
How has this been tested?
Old
TestG1AffineIsOnCurve
andTestG2AffineIsOnCurve
How has this been benchmarked?
e.g. BLS12-381 on AWS z1d.large:
G1
335 ns vs. 190.6 nsG2
624 ns vs. 495.3 nsCompared to geth/kilic (cc @asanso, @MariusVanDerWijden):
G1
320.7 ns vs. 190.6 nsG2
917.9 ns vs. 495.3 nsChecklist:
golangci-lint
does not output errors locally