Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken links #590

Merged
merged 6 commits into from
Dec 25, 2024
Merged

Update broken links #590

merged 6 commits into from
Dec 25, 2024

Conversation

vipocenka
Copy link
Contributor

This pull request addresses the following changes:

  1. Fixed a typo in pairing.go by updating the link reference for the algorithm from https://eprint.iacr.org/2021/1359.qdf to https://eprint.iacr.org/2021/1359.pdf.
  2. Updated the broken link in pedersen_hash_test.go from https://docs.starknet.io/documentation/develop/Contracts/contract-address/ to https://docs.starknet.io/docs/Contracts/contract-address.

These changes ensure better readability and usability of the references in the code.

Fixes: None directly linked but improves code documentation and references.


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Verified that the updated links are accessible and valid.

Checklist:

  • Performed a self-review of the changes.
  • Updated code comments to reflect the changes.
  • Verified tests to ensure existing functionalities remain intact.
  • Ensured compatibility with related modules.

Allow edits by maintainers

@ivokub ivokub changed the base branch from master to fix/typos-v0.15 December 25, 2024 23:23
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very good catch!

@ivokub ivokub merged commit e18f042 into Consensys:fix/typos-v0.15 Dec 25, 2024
ivokub pushed a commit that referenced this pull request Dec 25, 2024
ivokub pushed a commit that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants