fix: mod reduce input in solve with hint when coming from interface

Consensys · Feb 3, 2022 · 18f9ebd · 18f9ebd
1 parent e04e9ec
commit 18f9ebd
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 0 deletions.
diff --git a/internal/backend/bls12-377/cs/solution.go b/internal/backend/bls12-377/cs/solution.go
diff --git a/internal/backend/bls12-381/cs/solution.go b/internal/backend/bls12-381/cs/solution.go
diff --git a/internal/backend/bls24-315/cs/solution.go b/internal/backend/bls24-315/cs/solution.go
diff --git a/internal/backend/bn254/cs/solution.go b/internal/backend/bn254/cs/solution.go
diff --git a/internal/backend/bw6-633/cs/solution.go b/internal/backend/bw6-633/cs/solution.go
diff --git a/internal/backend/bw6-761/cs/solution.go b/internal/backend/bw6-761/cs/solution.go
diff --git a/internal/generator/backend/template/representations/solution.go.tmpl b/internal/generator/backend/template/representations/solution.go.tmpl
@@ -138,6 +138,8 @@ func (s *solution) solveWithHint(vID int, h *compiled.Hint) error {
 	inputs := s.tmpHintsIO[:nbInputs]
 	outputs := s.tmpHintsIO[nbInputs:nbInputs+nbOutputs]
 
+	q := fr.Modulus()
+
 	for i := 0; i < nbInputs; i++ {
 
 		switch t := h.Inputs[i].(type) {
@@ -153,6 +155,9 @@ func (s *solution) solveWithHint(vID int, h *compiled.Hint) error {
 		default:
 			v := utils.FromInterface(t)
 			inputs[i] = &v
+
+			// here we have no guarantee that v < q, so we mod reduce
+			inputs[i].Mod(inputs[i], q)
 		}
 	}