perf(bn254): optimize Miller loop #1254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In non-native arithmetic subtractions are costlier than additions. In this PR we re-arrange some subs into adds.
Type of change
How has this been tested?
All pairing tests pass.
How has this been benchmarked?
This PR saves 22,462 scs in the ECPAIR precompile of size 4. The bigger the size the more it saves (given that new points are added to the multi-Miller loop).
Checklist:
golangci-lint
does not output errors locally