Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README #1255

Merged
merged 13 commits into from
Sep 4, 2024
Merged

docs: update README #1255

merged 13 commits into from
Sep 4, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Aug 22, 2024

Add reference to gnark-crypto in the readme. We should also add the audit reports to the repository and link to them.

@ivokub ivokub added the doc label Aug 22, 2024
@ivokub ivokub requested a review from gbotrel August 22, 2024 10:55
@ivokub ivokub self-assigned this Aug 22, 2024
@ivokub ivokub marked this pull request as draft August 22, 2024 11:53
@ivokub ivokub marked this pull request as ready for review August 26, 2024 07:38
@ivokub ivokub requested a review from gbotrel September 3, 2024 11:34
@ivokub ivokub changed the title docs: add reference to gnark-crypto in README docs: update README Sep 3, 2024
@ivokub
Copy link
Collaborator Author

ivokub commented Sep 3, 2024

@gbotrel - rerequesting review. I updated README a bit more. Does it make sense or is it too long now?

See https://github.com/Consensys/gnark/tree/fix/readme

Copy link
Collaborator

@gbotrel gbotrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, approved with minor comments

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@ivokub ivokub requested a review from gbotrel September 4, 2024 11:50
@ivokub ivokub merged commit d55adc1 into master Sep 4, 2024
6 checks passed
@ivokub ivokub deleted the fix/readme branch September 4, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants