Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groth 16 MPC setup refactor #1297

Open
wants to merge 89 commits into
base: master
Choose a base branch
from
Open

Groth 16 MPC setup refactor #1297

wants to merge 89 commits into from

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Oct 11, 2024

This PR updates the Groth16 MPC setup to support BSB22 commitments.

@ivokub ivokub mentioned this pull request Nov 22, 2024
16 tasks
@Tabaie Tabaie marked this pull request as ready for review December 18, 2024 23:44
@Tabaie Tabaie changed the title Groth 16 MPC setup - code cleanup Groth 16 MPC setup Dec 18, 2024
@Tabaie Tabaie changed the title Groth 16 MPC setup Groth 16 MPC setup refactor Dec 19, 2024
@ivokub
Copy link
Collaborator

ivokub commented Dec 20, 2024

It seems the CI check fails due to Consensys/gnark-crypto#585 - here now in both cases encode and encodeRaw we encode the G1/G2 points as compressed, but Solidity checker assumes uncompressed it seems. When I reverted gnark-crypto upgrade then the failing test started to pass. But I think it is better to fix the other PR.

@Tabaie
Copy link
Contributor Author

Tabaie commented Dec 20, 2024

It seems the CI check fails due to Consensys/gnark-crypto#585 - here now in both cases encode and encodeRaw we encode the G1/G2 points as compressed, but Solidity checker assumes uncompressed it seems. When I reverted gnark-crypto upgrade then the failing test started to pass. But I think it is better to fix the other PR.

Yes that's it. Thank you! Just pushed a fix to the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants