Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emulated): enforce widths of packed limbs #368

Merged
merged 2 commits into from
Sep 14, 2022
Merged

fix(emulated): enforce widths of packed limbs #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8c2ff
fix(emulated): enforce widths of packed limbs
ivokub Sep 13, 2022
c85339e
fix: update emulated circuit stats
ivokub Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified internal/stats/latest.stats
View file
Open in desktop
Binary file not shown.
21 changes: 10 additions & 11 deletions std/math/emulated/field.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,6 @@ func (f *field[T]) Xor(a frontend.Variable, b frontend.Variable) frontend.Variab
f.AssertIsBoolean(els[1])
rv := f.api.Xor(els[0].Limbs[0], els[1].Limbs[0])
r := f.PackLimbs([]frontend.Variable{rv})

f.EnforceWidth(r)
return r
}

Expand All @@ -254,8 +252,6 @@ func (f *field[T]) Or(a frontend.Variable, b frontend.Variable) frontend.Variabl
f.AssertIsBoolean(els[1])
rv := f.api.Or(els[0].Limbs[0], els[1].Limbs[0])
r := f.PackLimbs([]frontend.Variable{rv})

f.EnforceWidth(r)
return r
}

Expand All @@ -265,8 +261,6 @@ func (f *field[T]) And(a frontend.Variable, b frontend.Variable) frontend.Variab
f.AssertIsBoolean(els[1])
rv := f.api.And(els[0].Limbs[0], els[1].Limbs[0])
r := f.PackLimbs([]frontend.Variable{rv})

f.EnforceWidth(r)
return r
}

Expand Down Expand Up @@ -342,8 +336,6 @@ func (f *field[T]) IsZero(i1 frontend.Variable) frontend.Variable {
f.api.Mul(res, f.api.IsZero(reduced.Limbs[i]))
}
r := f.PackLimbs([]frontend.Variable{res})

f.EnforceWidth(r)
return r
}

Expand Down Expand Up @@ -600,10 +592,17 @@ func (f *field[T]) One() Element[T] {
return f.oneConst
}

// PackLimbs returns a constant element from the given limbs. The
// returned element is not safe to use as an operation receiver.
// PackLimbs returns a constant element from the given limbs. The returned
// element is not safe to use as an operation receiver. The method constrains
// the limb widths.
func (f *field[T]) PackLimbs(limbs []frontend.Variable) Element[T] {
// TODO: check that every limb does not overflow the expected width
limbNbBits := int(f.fParams.BitsPerLimb())
for i := range limbs {
// bits.ToBinary restricts the least significant NbDigits to be equal to
// the limb value. This is sufficient to restrict for the bitlength and
// we can discard the bits themselves.
bits.ToBinary(f.api, limbs[i], bits.WithNbDigits(limbNbBits))
}

return Element[T]{
Limbs: limbs,
Expand Down