Remove double negative from ICPX transfer HUB -> MMU
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now for the MMU_INST_invalidCodePrefix instruction we have
SUCCESS_BIT = 1 <=> ICPX = 1
<=> [first byte is 0xEF]
Where the first byte is that of the prospective bytecode which the
RETURN instruction is attempting to deploy
OlivierBBB
changed the title
ICPX transfer HUB -> MMU
OlivierBBB
commented
Dec 11, 2024
| @@ -276,7 +276,7 @@ | |||
| ;; size ;; size | |||
| ;; ref_offset ;; reference offset | |||
| ;; ref_size ;; reference size | |||
| (- 1 (return-instruction---exception-flag-ICPX)) ;; success bit; this double negation stuff will be resolved by spec issue #715 | |||
| (return-instruction---exception-flag-ICPX) ;; success bit; this double negation stuff will be resolved by spec issue #715 | |||
There was a problem hiding this comment.
Removed first negation in the HUB
OlivierBBB
commented
Dec 11, 2024
|
|
||
| (defconstraint invalid-code-prefix---setting-the-success-bit (:guard (* MACRO IS_INVALID_CODE_PREFIX)) | ||
| (begin ;; setting tot nb of mmio inst | ||
| ;; setting the success bit | ||
| (eq! macro/SUCCESS_BIT | ||
| (- 1 (next prprc/WCP_RES))))) | ||
| (next prprc/WCP_RES)))) |
There was a problem hiding this comment.
Removed second negation in the MMU
lorenzogentile404
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specified in Consensys/linea-specification#29