Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed divergence from spec in the "return data size" macro for ECADD/ECMUL/ECPAIRING #549

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

OlivierBBB
Copy link
Collaborator

@OlivierBBB OlivierBBB commented Dec 13, 2024

Around page 326

image

The shorthand uses the PRC flags directly, not their "nontrivial" counterparts.

Edit. The nontrivial counterparts being

image

(defun (precompile-processing---ECADD_MUL_PAIRING---return-data-reference-size) (+ (* ECADD_RETURN_DATA_SIZE scenario/PRC_ECADD )
(* ECMUL_RETURN_DATA_SIZE scenario/PRC_ECMUL )
(* ECPAIRING_RETURN_DATA_SIZE scenario/PRC_ECPAIRING)))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed shorthand + moved it to the right spot

@OlivierBBB OlivierBBB merged commit 63968a3 into master Dec 13, 2024
2 checks passed
@OlivierBBB OlivierBBB deleted the EC-precompile-MMU-instruction-fix branch December 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant