Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Timer instance creation in SimpleTimerCapture #566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MozirDmitriy
Copy link

  • Add thread-safe Timer instance caching using ConcurrentHashMap
  • Implement getOrCreateTimer() method for Timer instance reuse
  • Modify captureTime methods to use cached Timer instances
  • Remove TODO comment as the improvement has been implemented

This change improves performance by reducing the number of Timer instances created and reusing existing ones from a thread-safe cache.

This PR implements issue(s) # N/A

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

- Add thread-safe Timer instance caching using ConcurrentHashMap
- Implement getOrCreateTimer() method for Timer instance reuse
- Modify captureTime methods to use cached Timer instances
- Remove TODO comment as the improvement has been implemented

This change improves performance by reducing the number of Timer instances
created and reusing existing ones from a thread-safe cache.

Signed-off-by: MozirDmitriy <dmitriymozir@gmail.com>
Copy link

cla-assistant bot commented Jan 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant