Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staterecovery - plugin rename and debug logging #593

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais force-pushed the staterecovery-part10 branch from 3f9278f to 8fd1e2c Compare January 22, 2025 15:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 68.87%. Comparing base (728487b) to head (068e2d8).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ils/src/main/kotlin/linea/testing/CommandRunner.kt 20.00% 15 Missing and 1 partial ⚠️
...zkevm/ethereum/MakefileContractDeploymentHelper.kt 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #593      +/-   ##
============================================
- Coverage     68.89%   68.87%   -0.02%     
  Complexity     1186     1186              
============================================
  Files           327      327              
  Lines         13128    13176      +48     
  Branches       1317     1319       +2     
============================================
+ Hits           9044     9075      +31     
- Misses         3535     3551      +16     
- Partials        549      550       +1     
Flag Coverage Δ *Carryforward flag
hardhat 98.74% <ø> (ø) Carriedforward from 7410363
kotlin 66.53% <20.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...zkevm/ethereum/MakefileContractDeploymentHelper.kt 44.44% <20.00%> (ø)
...ils/src/main/kotlin/linea/testing/CommandRunner.kt 72.58% <20.00%> (-25.25%) ⬇️

... and 4 files with indirect coverage changes

@jpnovais jpnovais requested a deployment to docker-build-and-e2e January 24, 2025 22:03 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants