Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover/wizard performance monitor #768

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Conversation

srinathln7
Copy link
Contributor

This PR implements issue(s) #

  • Implements performance monitor as a runtime property of the prover inside the wizard
  • Enables granular level profiling - profiling individual prover steps, or overall prover steps in a specific round or everything
  • By default, the performance is inactive and has to be explicitly turned on through the config .toml file
  • Reverts the RING-SIS commit to ensure the prover sanity check passes.
  • Tested the proof with a mainnet tracefile beta-v2.1-rc4.

To activate the performance monitor, add the following to your .toml file

[debug]
performance_monitor.active = true 
performance_monitor.profile_dir = "/home/ubuntu/archieve/profiling"
performance_monitor.profile = "prover-steps"

@srinathln7 srinathln7 self-assigned this Mar 11, 2025
Copy link

cla-assistant bot commented Mar 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Mar 11, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@srinathln7 srinathln7 added the Prover Tag to use for all work impacting the prover label Mar 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.86%. Comparing base (18b2cfc) to head (0eb277c).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #768   +/-   ##
=========================================
  Coverage     67.86%   67.86%           
  Complexity     1206     1206           
=========================================
  Files           326      326           
  Lines         13412    13412           
  Branches       1355     1355           
=========================================
  Hits           9102     9102           
  Misses         3750     3750           
  Partials        560      560           
Flag Coverage Δ *Carryforward flag
hardhat 98.53% <ø> (ø)
kotlin 65.51% <ø> (ø) Carriedforward from 9a4cbb1

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@srinathln7 srinathln7 deployed to docker-build-and-e2e March 11, 2025 21:18 — with GitHub Actions Active
@gusiri gusiri self-requested a review March 12, 2025 08:17
@srinathln7 srinathln7 enabled auto-merge (squash) March 12, 2025 08:19
@srinathln7 srinathln7 merged commit 8ddd4c1 into main Mar 12, 2025
24 of 25 checks passed
@srinathln7 srinathln7 deleted the prover/wizard-performance-monitor branch March 12, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants