Fix price adjustment in profitability formula (#642)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Consensys · Mar 6, 2024 · 8c046a7 · 8c046a7
1 parent 3985f62
commit 8c046a7
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/arithmetization/src/main/java/net/consensys/linea/bl/TransactionProfitabilityCalculator.java b/arithmetization/src/main/java/net/consensys/linea/bl/TransactionProfitabilityCalculator.java
@@ -28,12 +28,14 @@ public class TransactionProfitabilityCalculator {
 
   private final LineaProfitabilityConfiguration profitabilityConf;
   private final double preComputedValue;
+  private final double priceAdjustment;
 
   public TransactionProfitabilityCalculator(
       final LineaProfitabilityConfiguration profitabilityConf) {
     this.profitabilityConf = profitabilityConf;
     this.preComputedValue =
         profitabilityConf.gasPriceRatio() * profitabilityConf.verificationGasCost();
+    this.priceAdjustment = profitabilityConf.gasPriceAdjustment().getAsBigInteger().doubleValue();
   }
 
   public Wei profitablePriorityFeePerGas(
@@ -44,15 +46,14 @@ public Wei profitablePriorityFeePerGas(
     final double compressedTxSize = getCompressedTxSize(transaction);
 
     final var profitAt =
-        preComputedValue
-            * minMargin
-            * compressedTxSize
-            * minGasPrice.getAsBigInteger().doubleValue()
-            / (gas * profitabilityConf.verificationCapacity());
-
-    final var adjustedProfit =
-        Wei.ofNumber(BigDecimal.valueOf(profitAt).toBigInteger())
-            .add(profitabilityConf.gasPriceAdjustment());
+        (preComputedValue
+                    * compressedTxSize
+                    * minGasPrice.getAsBigInteger().doubleValue()
+                    / (gas * profitabilityConf.verificationCapacity())
+                + priceAdjustment)
+            * minMargin;
+
+    final var adjustedProfit = Wei.ofNumber(BigDecimal.valueOf(profitAt).toBigInteger());
 
     log.atDebug()
         .setMessage(