You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For reasons unknown, go-corset fails on the CI server for leoFailingRange when the zkevm.bin is compiled with corset version 9.7.14. The failure looks like some kind of resource limit is reached. For example, most likely, it is memory. In contract, corset itself passes this test without trouble. Despite this, go-corset passes that test easily on a laptop machine using a modest amount of memory (~25Gb). After a lot of investigation, no obvious explanation was found. Things investigated include:
Tweaking the GOMEMLIMIT
Tweaking the gradle config parameter maxParallelForks
Using REPLAY_TESTS_PARALLELISM: 1 in the workflow file for go-corset-tests.
Tweaking the batch size for go-corset.
Some things I didn't try yet include:
Tweaking GOMAXPROCS to limit number of CPUs available to go.
The text was updated successfully, but these errors were encountered:
Ok, so there is one explanation for the different between Rust corset and Go corset. Its not a fair fight!! Specifically, we are currently using these flags:
CORSET_FLAGS: fields,expand,expand,expand
But, we should be using these flags (to properly check with corset)
In contrast, go-corset uses the flag --air which is equivalent to the latter flags (i.e. the full set).
This probably explains why corset was not so affected by the changes in the zkevm.bin brought about by using corset version 9.7.14 (compared with the older version 9.7.13)
For reasons unknown,
go-corset
fails on the CI server forleoFailingRange
when thezkevm.bin
is compiled withcorset
version9.7.14
. The failure looks like some kind of resource limit is reached. For example, most likely, it is memory. In contract,corset
itself passes this test without trouble. Despite this,go-corset
passes that test easily on a laptop machine using a modest amount of memory (~25Gb). After a lot of investigation, no obvious explanation was found. Things investigated include:GOMEMLIMIT
gradle
config parametermaxParallelForks
REPLAY_TESTS_PARALLELISM: 1
in the workflow file forgo-corset-tests
.go-corset
.Some things I didn't try yet include:
GOMAXPROCS
to limit number of CPUs available togo
.The text was updated successfully, but these errors were encountered: