feat(replayTest): parametric #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBBB
reviewed
Sep 22, 2024
| } | ||
|
|
||
| private static void add(int start) { | ||
| blockNumbers.add(Arguments.of(start)); |
There was a problem hiding this comment.
Have you looked at the python script ? It produces a .csv file which you can then download in bulk with @gusiri 's bulk_capture script.
There was a problem hiding this comment.
Yes the python one, but cannot find the bulk_capture one. However, since the purpose of this test is having one parametric test per block, I believe it makes sense to download them one by one and have separated files.
There was a problem hiding this comment.
It's in arithmetization/src/tests/resources/bulk_capture.sh
…independent-parametrised-tests
…metrised-tests' of github.com:Consensys/linea-tracer into 1272-featreplaytests-split-ranges-into-independent-parametrised-tests
…independent-parametrised-tests
letypequividelespoubelles
requested changes
Sep 25, 2024
lorenzogentile404
deleted the
1272-featreplaytests-split-ranges-into-independent-parametrised-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.