Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: some cleaning in signals and module triggering #1293

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

letypequividelespoubelles
Copy link
Collaborator

No description provided.

Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles letypequividelespoubelles added the bug Something isn't working label Sep 24, 2024
@letypequividelespoubelles letypequividelespoubelles linked an issue Sep 24, 2024 that may be closed by this pull request
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles letypequividelespoubelles marked this pull request as ready for review September 24, 2024 07:39
@letypequividelespoubelles letypequividelespoubelles changed the title clean: just some cleaning for the moment clean: some cleaning in signals and module triggering Sep 24, 2024
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@letypequividelespoubelles letypequividelespoubelles merged commit 202e95a into arith-dev Sep 24, 2024
5 checks passed
@letypequividelespoubelles letypequividelespoubelles deleted the 1277-rom_lex-failing-ref-test branch September 24, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants