Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix'selfdestruct): immutable map #1337

Merged
merged 4 commits into from
Oct 1, 2024
Merged

fix'selfdestruct): immutable map #1337

merged 4 commits into from
Oct 1, 2024

Conversation

letypequividelespoubelles
Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles commented Oct 1, 2024 •
edited
Loading

This PR :

  • (fix) make the List of AttemptedSelfDestruct mutable
  • refactors the two records out of TransactionProcessingMetadata
  • makes some cleans with removing this.

@letypequividelespoubelles
refactor: put in separate class records, they have nothing to do in M…
35138ba 
…etaTx java

Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles letypequividelespoubelles linked an issue Oct 1, 2024 that may be closed by this pull request
Try to modify ImmutableCollection of selfdestruct #1332
Closed
@letypequividelespoubelles letypequividelespoubelles added bug Something isn't working reference test labels Oct 1, 2024
@letypequividelespoubelles
fix: don't use immutable List.of() + cleaning
2488834 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles letypequividelespoubelles marked this pull request as ready for review October 1, 2024 07:17
lorenzogentile404
lorenzogentile404 reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@lorenzogentile404 lorenzogentile404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is usually a good practice to keep List (interface type) instead of ArrayList (actual implementation type) when you declare the type. Beyond that, LGTM.

@lorenzogentile404 lorenzogentile404 enabled auto-merge (squash) October 1, 2024 13:52
@lorenzogentile404 lorenzogentile404 merged commit 4c9141d into arith-dev Oct 1, 2024
5 checks passed
@lorenzogentile404 lorenzogentile404 deleted the 1332-try-to-modify-immutablecollection-of-selfdestruct branch October 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzogentile404 lorenzogentile404 lorenzogentile404 approved these changes

Assignees

@letypequividelespoubelles letypequividelespoubelles

Labels
bug Something isn't working reference test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try to modify ImmutableCollection of selfdestruct
2 participants
@letypequividelespoubelles @lorenzogentile404