Fix: adding the chainId to the HUB and BLOCK_DATA modules
#1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBBB
requested review from
lorenzogentile404 and
letypequividelespoubelles
Closed
OlivierBBB
commented
Oct 2, 2024
| @@ -91,8 +91,10 @@ public ZkTracer(BigInteger chainId) { | |||
|
|
|||
| public ZkTracer( | |||
| final LineaL1L2BridgeSharedConfiguration bridgeConfiguration, BigInteger chainId) { | |||
| this.hub = new Hub(bridgeConfiguration.contract(), bridgeConfiguration.topic()); | |||
| this.chainId = chainId; | |||
| BigInteger nonnegativeChainId = chainId.abs(); | |||
There was a problem hiding this comment.
For some reason the chainId sometimes gets interpreted as a negative integer.
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
letypequividelespoubelles
requested changes
Oct 3, 2024
| BigInteger nonnegativeChainId = chainId.abs(); | ||
| this.hub = | ||
| new Hub(bridgeConfiguration.contract(), bridgeConfiguration.topic(), nonnegativeChainId); | ||
| this.chainId = nonnegativeChainId; |
There was a problem hiding this comment.
we just need to give it to the HUB, no need to keep it in the ZkTracer
letypequividelespoubelles
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.