Fixing issues with column sizes #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where casting it to (int) left us with a remainder mod some power of 2 instead of the actual accumulatedGasUsedInBlock
…o fill GasExpected correctly after resuming execution in a frame
| @@ -77,6 +77,14 @@ public boolean isHalt() { | |||
| return this.instructionFamily == InstructionFamily.HALT; | |||
| } | |||
|
|
|||
| public boolean isCall() { | |||
There was a problem hiding this comment.
We already have those method somewhere else (based on the opcode, not the opcode family)
There was a problem hiding this comment.
Yes. But it makes more sense to have them defined on the instruction family level.
There was a problem hiding this comment.
I moved these methods to the OpCodeData level.
- removed pushFlag from opcodes.yml - removed jumpFlag from opcodes.yml (which BTW was a misnomer) - make the isXxx() methods of OpCode.java return the same method from OpCodeData.java
letypequividelespoubelles
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.