Resolved issues related to column type changes #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBBB
requested review from
lorenzogentile404 and
letypequividelespoubelles
OlivierBBB
commented
Oct 15, 2024
| @@ -167,7 +167,7 @@ private void traceModexpResult(Trace trace, final UnsignedByte stamp) { | |||
|
|
|||
| private void commonTrace(Trace trace, UnsignedByte stamp, int index, Bytes input, int indexMax) { | |||
| trace | |||
| .stamp(stamp) | |||
| .stamp(stamp.toInteger()) | |||
There was a problem hiding this comment.
Not sure this is the right way to do this.
There was a problem hiding this comment.
looking at UnsignedByte.java it seems ok to me. It's used to convert to BigInt to
OlivierBBB
commented
Oct 15, 2024
OlivierBBB
commented
Oct 15, 2024
OlivierBBB
commented
Oct 15, 2024
OlivierBBB
commented
Oct 15, 2024
| @@ -185,14 +185,14 @@ public Trace trace(Trace trace) { | |||
| trace::pStackStackItemPop3, | |||
| trace::pStackStackItemPop4); | |||
|
|
|||
| final List<Function<Bytes, Trace>> heightTracers = | |||
| final List<Function<Short, Trace>> heightTracers = | |||
There was a problem hiding this comment.
Short was suggested by Intellij
OlivierBBB
commented
Oct 15, 2024
| .heightNew( | ||
| commonFragmentValues.hubProcessingPhase == HubProcessingPhase.TX_EXEC | ||
| ? commonFragmentValues.heightNew | ||
| : 0) |
There was a problem hiding this comment.
HEIGHT and HEIGHT_NEW vanish outside of execution rows.
OlivierBBB
commented
Oct 15, 2024
|
What I'm most worried about is the change of the constraints commit 🤔 |
letypequividelespoubelles
approved these changes
Oct 15, 2024
| @@ -167,7 +167,7 @@ private void traceModexpResult(Trace trace, final UnsignedByte stamp) { | |||
|
|
|||
| private void commonTrace(Trace trace, UnsignedByte stamp, int index, Bytes input, int indexMax) { | |||
| trace | |||
| .stamp(stamp) | |||
| .stamp(stamp.toInteger()) | |||
There was a problem hiding this comment.
looking at UnsignedByte.java it seems ok to me. It's used to convert to BigInt to
| .ct(Bytes.of(i)) | ||
| .inst(Bytes.of(this.opCode.byteValue())) | ||
| .ct(i) | ||
| .inst(UnsignedByte.of(this.opCode.byteValue())) |
There was a problem hiding this comment.
you could use opCode.unsignedByteValue()
| @@ -135,7 +134,7 @@ public void traceLog(final Log log, final int absLogNum, final int absLogNumMax, | |||
| .logsData(true) | |||
| .sizeTotal(log.getData().size()) | |||
| .sizeAcc(index == indexMax ? log.getData().size() : 16L * (index + 1)) | |||
| .sizeLimb(index == indexMax ? UnsignedByte.of(lastLimbSize) : UnsignedByte.of(16)) | |||
| .sizeLimb(index == indexMax ? lastLimbSize : 16) | |||
There was a problem hiding this comment.
use LLARGE
| @@ -111,7 +113,8 @@ public int lineCount() { | |||
|
|
|||
| @Override | |||
| public List<ColumnHeader> columnsHeaders() { | |||
| return Trace.headers(this.lineCount()); | |||
| return headers(this.lineCount()); | |||
| // return Trace.headers(this.lineCount()); | |||
There was a problem hiding this comment.
why keeping the comment ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.