fix: support regeneration of GlobalConstants.java (#952)
#1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
952-enable-regenerate-globalconstantjava
branch
from
0087a35 to
6ca86e4
Compare
This enables regeneration of the `GlobalConstants.java` via the command `gradle constants`. This requires Corset `v9.7.15` (which at this time has not yet been released). The solution is to allow for an override to the class name being produced in Corset. So, it doesn't always have to generate a file `Trace.java`. Rather you can specify the class name to generate (in this case, `GlobalConstants`). The relevant gradle option for the `constants` command is updated to do this.
DavePearce
force-pushed
the
952-enable-regenerate-globalconstantjava
branch
2 times, most recently
from
70d8dcf to
e121dc2
Compare
DavePearce
requested review from
gauravahuja and
FlorianHuc
and removed request for
letypequividelespoubelles
gauravahuja
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables regeneration of the
GlobalConstants.javavia the commandgradle constants. This requires Corsetv9.7.15(which at this time has not yet been released). The solution is to allow for an override to the class name being produced in Corset. So, it doesn't always have to generate a fileTrace.java. Rather you can specify the class name to generate (in this case,GlobalConstants). The relevant gradle option for theconstantscommand is updated to do this.