Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some HUB debugging #1467

Merged
merged 43 commits into from
Nov 4, 2024
Merged

some HUB debugging #1467

merged 43 commits into from
Nov 4, 2024

Conversation

letypequividelespoubelles
Copy link
Collaborator

No description provided.

@letypequividelespoubelles
add HUB constraints
e633bf3 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles letypequividelespoubelles linked an issue Oct 30, 2024 that may be closed by this pull request
Some HUB debugging #1465
Closed
@letypequividelespoubelles
Merge branch 'arith-dev' into 1465-some-hub-debugging
ac14db6
@OlivierBBB
fix: typo in the CREATE
a3afbba
@OlivierBBB
ras: cosmetic
3cc19e2
@OlivierBBB
ras: new tests + fix
5833618
@OlivierBBB
ras: GASPRICE = 8 Wei/gas and VALUE = 1 Wei for base transactions
19311d2
@OlivierBBB
spotless
0491017
@OlivierBBB
fix: make GAS_NEXT vanish in case of an exception
7407550
@OlivierBBB
fix: (2,0)-stack-pattern fixed 2nd stack item's height
ca2604a
@letypequividelespoubelles
really nothing
1cd5fe1 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
Merge branch 'arith-dev' into 1465-some-hub-debugging
5f2b2d7
@OlivierBBB
ras
1cd9e01
@OlivierBBB
fix: the current context provides "outputData" which becomes the pare…
21678a2 
…nt's "returnData"

This fixed

return-instruction---setting-the-callers-new-return-data-message-call-case
@OlivierBBB
fix: REVERT now provides the adequate return data to the caller
1563918 
this fixes

revert-instruction---setting-the-context-rows---unexceptional
@letypequividelespoubelles
fix lookup hub into mmu and rlpAddr for create(2) + spotless
7a29480 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
clean up in signals
6ee97ef 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
use alpha / delta instead of added / remove to catch SUX/SOX
c28dced 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
fix hasCode in accountFragment
e7a5627 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
tiny cleaning
776b8b9 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@OlivierBBB
fix: some progress on gasCostToTrace()
97ff6e3
@OlivierBBB
fix: traceLog() now takes the right "willRevert" into account
1e618fc
@OlivierBBB
fix: opcodes.yml reflects spec change for TXN instruction family
a1d18d7 
We now have
  DEC_FLAG_1 = true for ORIGIN
  DEC_FLAG_2 = true for GASPRICE
@OlivierBBB
fix: opcodes.yml didn't include updated values for SLOAD/SSTORE
8479456 
fixed

   storage-instruction---stack-pattern
@OlivierBBB OlivierBBB force-pushed the 1465-some-hub-debugging branch from db7e340 to 8479456 Compare October 31, 2024 15:38
@OlivierBBB
fix: LOG1 had issue with its stack pattern
bb2c8a2 
fixed

   log-instruction---setting-the-stack-pattern
@OlivierBBB
fix: providing the correct value to context/CALL_DATA_CONTEXT_NUMBER
3149332 
fixes

   stack-ram---setting-MMU-instruction---CALLDATALOAD-case
@OlivierBBB
spotless
5a816ce
@OlivierBBB
ras
af73476
@OlivierBBB OlivierBBB marked this pull request as ready for review October 31, 2024 23:10
@letypequividelespoubelles
update consyraint to latest master wo HUB
c3792f4 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
fix constraints
caae34d 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@OlivierBBB
fix: removed old "Unconstrained FIRST/FINAL" columns from storage per…
639e0e9 
…spectives
@OlivierBBB
ras
3e73fb7
@OlivierBBB
fix: EXTCODECOPY stack pattern was off
7d4281a 
this fixes

   hub.copy-instruction---setting-the-stack-pattern
@OlivierBBB OlivierBBB force-pushed the 1465-some-hub-debugging branch from 6853bb2 to 7d4281a Compare November 1, 2024 15:38
@OlivierBBB
fix: RETURNDATACOPY fragment order
303e6f8 
this fixed

  copy-instruction---setting-NSR-and-peeking-flags---RETURNDATACOPY-case
@OlivierBBB
fix: MSIZE requires its own TraceSection
b0391c2 
this fixes

   machine-state-instruction---setting-stack-value---MSIZE-case
@OlivierBBB
fix: EXTCODECOPY doesn't have a static cost
be9e128 
to be precise, it has a warming cost but that's separate from the static
cost in our arithmetization.

This fixed

  hub-into-instdecoder
@OlivierBBB OlivierBBB force-pushed the 1465-some-hub-debugging branch from 891ed94 to be9e128 Compare November 1, 2024 17:47
@OlivierBBB
ras: added names to the CREATE stack pattern function
e88c9c3
@OlivierBBB
fix: make it compile + renaming to follow the constraints
0b0599b 
the constraints saw the following change:

   MULTIPLIER___STACK_HEIGHT -> MULTIPLIER___STACK_STAMP

and this reflects it. Also the constraints change fixed

   hub.create-instruction---setting-the-stack-pattern
@OlivierBBB
fix: removed redundant method in CallStack
47f1407
@OlivierBBB
fix: returnDataTargetInCaller major update
92b4080 
- made it final
- made other fields final
- set it with the enter() method
- don't set that of the caller ! but of the callee :)
@letypequividelespoubelles letypequividelespoubelles changed the title add HUB constraints some HUB debugging Nov 2, 2024
@letypequividelespoubelles
spotless
a7d6274 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
constrains
7ef113e 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
fix(logSection): triggers log revert with the callframe.willrevert()
5f36617 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles
Merge branch 'arith-dev' into 1465-some-hub-debugging
6ade93f
@OlivierBBB OlivierBBB merged commit 10d5745 into arith-dev Nov 4, 2024
4 of 5 checks passed
@OlivierBBB OlivierBBB deleted the 1465-some-hub-debugging branch November 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBBB OlivierBBB OlivierBBB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some HUB debugging
2 participants
@letypequividelespoubelles @OlivierBBB