Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modexp): add debuged failing ref test #1500

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

letypequividelespoubelles
Copy link
Collaborator

No description provided.

Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@letypequividelespoubelles letypequividelespoubelles added the bug Something isn't working label Nov 15, 2024
@letypequividelespoubelles letypequividelespoubelles linked an issue Nov 15, 2024 that may be closed by this pull request
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@@ -122,7 +122,7 @@ public EWord rawLeadingWord() {
}

public boolean extractModulus() {
return (callData.size() > MBS_MIN_OFFSET + bbsInt() + ebsInt()) && !mbs().isZero();
return (callData.size() > BASE_MIN_OFFSET + bbsInt() + ebsInt()) && !mbs().isZero();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only fix :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@letypequividelespoubelles letypequividelespoubelles merged commit ef2e663 into arith-dev Nov 15, 2024
5 checks passed
@letypequividelespoubelles letypequividelespoubelles deleted the 1497-debug_modexpreference_test branch November 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modexp_d20g0v0_London size has value 0.
2 participants