Refactoring to use test watcher for unit tests as well. #1513
Conversation
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
…/watch-unit-tests
…/watch-unit-tests
| @@ -105,6 +119,16 @@ public class BlockchainReferenceTestTools { | |||
| // Absurd amount of gas, doesn't run in parallel. | |||
There was a problem hiding this comment.
I imagine that the CALL50000 could prove problematic with the MemoryRange implementation we currently have @letypequividelespoubelles ^^ If we have to keep 50k snapshots of memory ^^ I mean, it's not an issue. But I wonder whether the tests that @amkCha was able to run again on that 64GB machine would crash with our current tracer.
reference-tests/src/test/java/net/consensys/linea/BlockchainReferenceTestTools.java
Show resolved
Hide resolved
.../consensys/linea/zktracer/instructionprocessing/callTests/prc/ecrecover/GasStipendTests.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public static void addSkipped() { | ||
| disabledCounter.incrementAndGet(); |
There was a problem hiding this comment.
It's strange that we talk about disabled and skipped rather than having one word for both. Presumably disabled makes the most sense if it in any way involves the @Disabled annotation (which I have no idea if it does or not)
There was a problem hiding this comment.
it comes from the interface i implement. So I guess it's standard.
| @@ -105,6 +119,16 @@ public class BlockchainReferenceTestTools { | |||
| // Absurd amount of gas, doesn't run in parallel. | |||
| PARAMS.ignore("randomStatetest94_\\w+"); | |||
|
|
|||
| // Balance is more than 128 bits | |||
| PARAMS.ignore(("Call1024PreCalls_d0g0v0_London[London]")); | |||
There was a problem hiding this comment.
is it normal to have double bracket @FlorianHuc ?
No description provided.