fix: incorrect generation of Trace.java files
#1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to specify `className=Trace` in the `trace-files.gradle` build file, by allowing the default (which is `Trace.java`) to be used when this is not specified.
DavePearce
force-pushed
the
1523-incorrect-generation-of-tracejava-for-instruction-decoder
branch
from
675e307 to
33c700e
Compare
gauravahuja
approved these changes
Nov 20, 2024
| "-o", "${project.projectDir}/src/main/java/net/consensys/linea/zktracer/module/${moduleDir.getOrElse(module.get())}" | ||
| ] | ||
| if(className) { | ||
| if(project.hasProperty("className")) { |
There was a problem hiding this comment.
I wonder if this would be better
Suggested change
| if(project.hasProperty("className")) { | |
| if(className.isPresent()) { |
…for-instruction-decoder
OlivierBBB
deleted the
1523-incorrect-generation-of-tracejava-for-instruction-decoder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the groovy task
TraceFilesTask.groovywhich was not accounting correctly for modules located in subdirectories. Specifically, it wasn't generating the correct Java package name.