Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove non-determinism from tests #1537

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

DavePearce
Copy link
Collaborator

This removes non-determinism from the tests caused by a shared RNG across tests.

This removes non-determinism from the tests caused by a shared RNG
across tests.
@DavePearce DavePearce linked an issue Nov 21, 2024 that may be closed by this pull request
This disables three tests which lead to an overflow of the
`hub/RETURN_DATA_OFFSET` column during trace generation.  See #1538.
@DavePearce DavePearce enabled auto-merge (squash) November 22, 2024 01:20
Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@DavePearce DavePearce merged commit 8353d02 into arith-dev Nov 22, 2024
5 checks passed
@DavePearce DavePearce deleted the 1536-remove-randomness-from-mxp-tests branch November 22, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Randomness from MXP tests
2 participants