fix: go-corset running test in CI
#1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
1553-fix-go-corset-in-fastreplaytests1
branch
from
0dd151d to
0848a6b
Compare
DavePearce
force-pushed
the
1553-fix-go-corset-in-fastreplaytests1
branch
4 times, most recently
from
187dd4d to
04658a7
Compare
DavePearce
force-pushed
the
1553-fix-go-corset-in-fastreplaytests1
branch
from
04658a7 to
77266ff
Compare
gauravahuja
requested changes
Nov 25, 2024
DavePearce
force-pushed
the
1553-fix-go-corset-in-fastreplaytests1
branch
2 times, most recently
from
5238276 to
f9dccd4
Compare
This disables the use of parallel forks in gradle unless this is explicitly requested. The issue is that parallel forks interferes with go-corset which is highly concurrent. Hence, running go-corset tasks in parallel can (in some cases) lead to out-of-resource issues and workflow tasks being cancelled unexpectedly. However, since using parallel forks does improve the runtime for Rust corset, this option is retained when specifically specified via the REPLAY/WEEKLY/REFERENCE_TESTS_PARALLELISM environment variables.
This allows the level of parallelism used for the unit tests to be configured via an environment variable `UNIT_TESTS_PARALLELISM`. Specifically, if this is left unset then no parallelism is used (which is desirable when running go-corset).
DavePearce
force-pushed
the
1553-fix-go-corset-in-fastreplaytests1
branch
from
f9dccd4 to
649c0b0
Compare
gauravahuja
reviewed
Nov 26, 2024
Comment on lines
+121
to
+127
| if (System.getenv().containsKey("UNIT_TESTS_PARALLELISM")) { | ||
| // Only set this if parallelism is explicitly requested. | ||
| // Specifically, because this option is not compatible with | ||
| // go-corset. | ||
| maxParallelForks = System.getenv().get("UNIT_TESTS_PARALLELISM").toInteger() | ||
| println "Enabled parallel forks." | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (System.getenv().containsKey("UNIT_TESTS_PARALLELISM")) { | |
| // Only set this if parallelism is explicitly requested. | |
| // Specifically, because this option is not compatible with | |
| // go-corset. | |
| maxParallelForks = System.getenv().get("UNIT_TESTS_PARALLELISM").toInteger() | |
| println "Enabled parallel forks." | |
| } | |
| System.getenv().getOrDefault("UNIT_TESTS_PARALLELISM", "1").toInteger()) |
gauravahuja
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the use of parallel forks in gradle unless this is
explicitly requested. The issue is that parallel forks interferes with
go-corset which is highly concurrent. Hence, running go-corset tasks in
parallel can (in some cases) lead to out-of-resource issues and workflow
tasks being cancelled unexpectedly.
However, since using parallel forks does improve the runtime for Rust
corset, this option is retained when specifically specified via the
UNIT_TESTS_PARALLELISM environment variable.