Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update equals on wcpoperation due to Bytes32 equal method inconsistency. #1573

Merged
merged 5 commits into from
Nov 27, 2024
Merged

update equals on wcpoperation due to Bytes32 equal method inconsistency. #1573

merged 5 commits into from
Nov 27, 2024

Conversation

FlorianHuc
Copy link
Collaborator

No description provided.

ahamlat
ahamlat approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@ahamlat ahamlat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add few more tests to check that different Eword returns false when calling equals

@FlorianHuc FlorianHuc enabled auto-merge (squash) November 27, 2024 13:34
@letypequividelespoubelles letypequividelespoubelles linked an issue Nov 27, 2024 that may be closed by this pull request
lineCounting issue in WCP #1564
Closed
@FlorianHuc FlorianHuc merged commit 04c08c3 into arith-dev Nov 27, 2024
5 checks passed
@FlorianHuc FlorianHuc deleted the fix/wcpequals branch November 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letypequividelespoubelles letypequividelespoubelles letypequividelespoubelles left review comments

@ahamlat ahamlat ahamlat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lineCounting issue in WCP
3 participants
@FlorianHuc @ahamlat @letypequividelespoubelles