Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: update name of prec limits to avoid confusion with old geth name #506

Merged
merged 4 commits into from
Dec 19, 2023
Merged

style: update name of prec limits to avoid confusion with old geth name #506

merged 4 commits into from
Dec 19, 2023

Conversation

letypequividelespoubelles
Copy link
Collaborator

No description provided.

@letypequividelespoubelles letypequividelespoubelles linked an issue Dec 19, 2023 that may be closed by this pull request
avoid confusion for PRECOMPILE_LIMITS module name #505
Closed
@letypequividelespoubelles
Copy link
Collaborator Author

so @FlorianHuc the idea is :

  • we use new names for the new limits on Besu/main (tipically number of relevant (ie without exceptions, etc) call, weighted by the size of the call (nb of blocks for hash precompile)
  • on the temp branch, I'll create/rename module which counts the number of call to the precompile (even if not succesfull because of exceptions) and give them the same name as in Geth.
    Is it ok for you ?

@letypequividelespoubelles letypequividelespoubelles merged commit 27f6af8 into main Dec 19, 2023
6 checks passed
@letypequividelespoubelles letypequividelespoubelles deleted the style/issue-505/avoid-confusion-for-precompile_limits-module-name branch December 19, 2023 12:56
powerslider pushed a commit that referenced this pull request Dec 21, 2023
@letypequividelespoubelles @powerslider
style: update name of prec limits to avoid confusion with old geth na…
692f696 
…me (#506)

* style: update name of prec limits to avoid confusion with old geth name

* style: update module name

* style: update name in .toml files

* style: remove NB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianHuc FlorianHuc FlorianHuc approved these changes

@delehef delehef Awaiting requested review from delehef

Assignees

@letypequividelespoubelles letypequividelespoubelles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

avoid confusion for PRECOMPILE_LIMITS module name
3 participants
@letypequividelespoubelles @delehef @FlorianHuc