-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mechanics to capture conflations & replay them as test cases #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delehef
force-pushed
the
feat/block-capture
branch
3 times, most recently
from
January 22, 2024 19:14
f2cc8e4
to
7350c60
Compare
delehef
changed the title
feat: mechanices to capture conflations & replay them as test cases
feat: mechanics to capture conflations & replay them as test cases
Jan 22, 2024
delehef
force-pushed
the
feat/block-capture
branch
2 times, most recently
from
January 23, 2024 09:19
42c2ef7
to
40893ef
Compare
arithmetization/src/test/java/net/consensys/linea/zktracer/ReplaysTests.java
Outdated
Show resolved
Hide resolved
letypequividelespoubelles
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
delehef
force-pushed
the
feat/block-capture
branch
from
January 24, 2024 08:37
40893ef
to
2a32fb3
Compare
delehef
force-pushed
the
feat/block-capture
branch
from
January 24, 2024 09:59
29df20d
to
7c8f889
Compare
delehef
force-pushed
the
feat/block-capture
branch
from
January 24, 2024 10:01
7c8f889
to
6a7c356
Compare
powerslider
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two feature:
rollup_captureConflation
, accepting a first and last block asparams
, and returning a JSON-encoded representation of the minimal set of information required to replay the given block range without requiring a fully-synchronized blockchain state, e.g.:ReplaysTests.replay(String fileName)
static method.