Use compressed tx size also when selecting txs from block creation #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Yes, txpool acceptance criteria (using From what I understand, this PR aligns the behavior, and the PR to transform this ratio ( |
gauravahuja
approved these changes
Feb 13, 2024
arithmetization/src/main/java/net/consensys/linea/bl/TransactionProfitabilityCalculator.java
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@julien-marchand this PR uses the compressed tx size also when calculating the profitability during block creation, so it is aligned with the
linea_estimateGasendpoint, is that correct?FYI: @macfarla @pinges check
private double getCompressedTxSize(final Transaction transaction) {for the integration of thegnarkCompression