Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize refundedGas for big transactions #793

Merged

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented Jun 25, 2024

Parallelizing postRetcon and refundedGas improved the performances by around 10 %

Before this PR

  • Number of blocks : 97, each block is 7 million gas
  • Mean: 1092.57 ms
  • Median: 1093.0 ms
  • 75th Percentile: 1128.0 ms
  • 95th Percentile: 1182.0 ms
  • 99th Percentile: 1188.75 ms
image

With this PR

  • Number of blocks ': 99, each block is 7 million gas
  • Mean: 993.59 ms
  • Median: 951.0 ms
  • 75th Percentile: 1082.5 ms
  • 95th Percentile: 1220.3 ms
  • 99th Percentile: 1260.45 ms
image

Fixes #792

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
@letypequividelespoubelles
Copy link
Collaborator

I would like this PR to be on stand by, because we might change how we compute the refundGas in the hub, and we might not be able to parallelize in near future

ahamlat and others added 2 commits June 27, 2024 19:58
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
@powerslider powerslider merged commit 8f6295a into arith-dev Jul 19, 2024
5 checks passed
@powerslider powerslider deleted the perf/issue-792/parallelize-for-big-transactions branch July 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big transactions are slow to trace and have a big memory footpring
3 participants