[831] New ToyExecutionEnvironment that build the General State Test Case spec to run tests #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravahuja
requested review from
powerslider,
tsvdesign,
FlorianHuc and
thedarkjester
and removed request for
tsvdesign
|
The approach looks good to me. Did you rewrite a unit test using ToyExecutionEnvironmentV2? |
@FlorianHuc I updated the MXPTest to use the new approach. |
gauravahuja
force-pushed
the
gauravahuja/831
branch
from
3783fad to
11cdf43
Compare
FlorianHuc
approved these changes
Aug 1, 2024
powerslider
force-pushed
the
gauravahuja/831
branch
from
9ae19b1 to
d340eab
Compare
powerslider
approved these changes
Aug 16, 2024
|
Have you tried tests to see if this fixes known issues @powerslider ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a copy of GeneralStateTestCaseEipSpec from the besu repo and a copy of ToyExecutionEnvironment as ToyExecutionEnvironmentV2 for faster iteration.
ToyExecutionEnvironmentV2 is very similar to ToyExecutionEnvironment but builds the GeneralStateTestCaseEipSpec and has a method to execute the test using the spec.
#831