feat: improve design of shared and private CLI options #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
reviewed
Jul 25, 2024
Comment on lines
25
to
29
| /** | ||
| * In this class we put CLI options that are private to plugins in this repo. | ||
| * | ||
| * <p>For the moment is just a placeholder since there are no private options | ||
| */ |
| @@ -63,6 +65,11 @@ private void createAndRegister( | |||
| method.getNamespace(), method.getName(), method::execute); | |||
| } | |||
|
|
|||
| @Override | |||
| public Map<String, LineaOptionsPluginConfiguration> getLineaPluginConfigMap() { | |||
| return Map.of(); | |||
There was a problem hiding this comment.
Maybe here doesn't make a difference, but in general should call var superMap = super.getLineaPluginConfigMap() and add local mapping to the superMap
| private BesuContext besuContext; | ||
| private RpcEndpointService rpcEndpointService; | ||
|
|
||
| @Override | ||
| public Map<String, LineaOptionsPluginConfiguration> getLineaPluginConfigMap() { | ||
| final TracesEndpointCliOptions tracesEndpointCliOptions = TracesEndpointCliOptions.create(); |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
approved these changes
Jul 25, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.