Only add needed dependencies in the uber jar #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
powerslider
reviewed
Aug 12, 2024
powerslider
reviewed
Aug 12, 2024
powerslider
approved these changes
Aug 12, 2024
…uber-jar # Conflicts: # arithmetization/build.gradle # gradle.properties # gradle/dependency-management.gradle # gradle/dist.gradle # reference-tests/build.gradle
fab-10
force-pushed
the
feat/issue-923/remove-the-need-for-the-uber-jar
branch
from
df843fe to
c25f8ca
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
feat/issue-923/remove-the-need-for-the-uber-jar
branch
from
b03d935 to
e706fd0
Compare
fab-10
changed the title
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the produced jar to only contains dependencies that are not already provided by Besu.
When adding a new dependency, as first thing verify it is already provided by Besu BOM, if yes then no need to declare it in the
dependency-management.gradlefile, use it in the required project.If a dependency that is not already provided by Besu is required, then declare it in the
dependency-management.gradlefile, and mostly important usepluginImplementationconfiguration to use it in the project, this way it will be also included in the final jar.This approach avoid duplicating dependencies classes in the final jar, and so reduces the jar size, and reduces the risk of classes clashes and errors at runtime.
fixes #923