fix: swap ordering of r/s fields in tx snapshot #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ordering of these two fields was incorrect, and should be swapped. This then means the TX hashes are computed correctly. Since this happens on the capture side, changes will only be noticed once the fix is deployed and new blocks captured. Existing captures contain the `r` and `s` fields in the wrong order, and need to be updated.
DavePearce
deleted the
fix/issue-945/incorrect-ordering-of-r-and-s-in-transactionsnapshotof
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering of these two fields was incorrect, and should be swapped. This then means the TX hashes are computed correctly. Since this happens on the capture side, changes will only be noticed once the fix is deployed and new blocks captured. Existing captures contain the
randsfields in the wrong order, and need to be updated.