fix: ToyWorld.commit() parent update
#966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
fix/issue-964/incorrect-implementation-of-toyworldcommit
branch
from
bb28047 to
76a0baf
Compare
This puts through a simple fix for `ToyWorld.commit()` and also tidies up `ToyWorld` a little by removing the `accounts` field which is not needed (as was incorrectly managed).
DavePearce
force-pushed
the
fix/issue-964/incorrect-implementation-of-toyworldcommit
branch
from
76a0baf to
3bfad80
Compare
|
@DavePearce Does this fix this long standing issue wrt |
|
@OlivierBBB Yes, in a sense it does because it removes the |
powerslider
approved these changes
Aug 23, 2024
powerslider
changed the title
ToyWorld.commit()ToyWorld.commit() parent update
DavePearce
deleted the
fix/issue-964/incorrect-implementation-of-toyworldcommit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts through a simple fix for
ToyWorld.commit()and also tidies upToyWorlda little by removing theaccountsfield which is not needed (as was incorrectly managed).