Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for handling override keyword #9

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Add tests for handling override keyword #9

merged 2 commits into from
Apr 28, 2020

Conversation

fvictorio
Copy link

This adds some failing tests for functions that use the override keyword. See the expected value for the proposed structure of the AST for this nodes.

@fvictorio fvictorio mentioned this pull request Feb 26, 2020
Open
@fvictorio
Copy link
Author

Added the missing test mentioned by @nicholaspai and also implemented the functionality.

@GNSPS could you take a look?

@fvictorio
Copy link
Author

@GNSPS friendly ping

@maurelian maurelian mentioned this pull request Apr 28, 2020
Merged
@maurelian maurelian merged commit dc65a4b into Consensys:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fvictorio @nicholaspai @maurelian