resolves #38. Errorprone causes issues with the build when this setti…

…ng is on check('FieldCanBeFinal', CheckSeverity.WARN) (#44)
Consensys · Dec 20, 2018 · a3d7afe · a3d7afe
1 parent 9333938
commit a3d7afe
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/...s/src/main/java/tech/pegasys/artemis/datastructures/BeaconChainState/ValidatorRecord.java b/...s/src/main/java/tech/pegasys/artemis/datastructures/BeaconChainState/ValidatorRecord.java
@@ -28,9 +28,7 @@ public class ValidatorRecord {
  private UInt64 latest_status_change_slot;
  private UInt64 exit_count;
 
- public ValidatorRecord(){}
-
- public ValidatorRecord(int pubkey, Hash withdrawal_credentials, Hash randao_commitment,
+ public ValidatorRecord(int pubkey, Hash withdrawal_credentials, Hash randao_commitment,
  UInt64 randao_layers, UInt64 deposit, UInt64 status, UInt64 slot, UInt64 exit_count) {
  this.pubkey = new UInt384(pubkey);
  this.withdrawal_credentials = withdrawal_credentials;

diff --git a/artemis/src/main/java/tech/pegasys/artemis/state/BeaconState.java b/artemis/src/main/java/tech/pegasys/artemis/state/BeaconState.java
@@ -68,11 +68,6 @@ public class BeaconState {
  private Hash processed_pow_receipt_root;
  private ArrayList<CandidatePoWReceiptRootRecord> candidate_pow_receipt_roots;
 
- // Default Constructor
- public BeaconState()
- {
- }
-
  public BeaconState(
  // Misc
  UInt64 slot, UInt64 genesis_time, ForkData fork_data,

diff --git a/build.gradle b/build.gradle
@@ -119,7 +119,7 @@ allprojects {
  // We use the JSR-305 annotations instead of the Google annotations.
  check('ImmutableEnumChecker', CheckSeverity.OFF)
 
- check('FieldCanBeFinal', CheckSeverity.WARN)
+ check('FieldCanBeFinal', CheckSeverity.OFF)
  check('InsecureCryptoUsage', CheckSeverity.WARN)
  check('WildcardImport', CheckSeverity.WARN)
  }